DESCRIPTION

Bug 488810 - IOException in RuntimeProcessFactory.whichCommand

- add a check for CoreException in launching a profiling tool
  and open an error dialog with error message instead of passing the
  exception all the way to the platform
- also add try/catch around the request for the valgrind version

Change-Id: I2875c66235b2c708ce598dc0e2f535ae46fc8ecd


COMMENTS

author: Kaylin Maxwell
date: 2016-03-11 19:24:49.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2016-03-11 19:24:55.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/10582/

-------------------------------------
author: Kaylin Maxwell
date: 2016-03-11 19:28:05.000000000

Patch Set 2:

I believe that the error dialog should be a catch-all in the Profiling launch but I agree with your comment that the check for the version should be protected in the Valgrind Launch delegate.  The method is supposed to throw a CoreException so the caller should protect against other forms of CoreExceptions other than the one we are seeing for a version check on Windows where no Valgrind is installed.

-------------------------------------
author: Brenden Conley
date: 2016-03-11 19:29:07.000000000

Patch Set 2: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/10582/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2016-03-11 21:29:56.000000000

Patch Set 2: -Verified

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/10587/

-------------------------------------
author: Brenden Conley
date: 2016-03-11 21:44:58.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/10587/ : SUCCESS

-------------------------------------
author: Brenden Conley
date: 2016-03-11 23:46:24.000000000

Patch Set 2: -Verified

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/10589/

-------------------------------------
author: Brenden Conley
date: 2016-03-12 00:02:04.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/10589/ : SUCCESS

-------------------------------------
author: Kaylin Maxwell
date: 2016-03-15 21:24:52.000000000

Patch Set 2: Code-Review+2

-------------------------------------
author: Gerrit Code Review
date: 2016-03-15 21:24:59.000000000

Change has been successfully cherry-picked as e8cb8af2e76b4be6f84da14827ce40f42f4764db by Kaylin Maxwell

-------------------------------------
