DESCRIPTION

Bug 482936 - Provide a generic field for extra valgrind options

Signed-off-by: Ishaan Salas xxx@xxx.xxx
Change-Id: I78b2fea9f1cbf951f6322fd5f893b0225e866491


COMMENTS

author: Julian Foster
date: 2015-11-24 18:53:21.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2015-11-24 18:53:27.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/10105/

-------------------------------------
author: Brenden Conley
date: 2015-11-24 19:10:35.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/10105/ : SUCCESS

-------------------------------------
author: Nathanael Holden
date: 2015-11-24 21:51:17.000000000

Patch Set 2: Code-Review+1 Verified-1

(1 comment)

This looks fine to me, but just one small change needed to register changes.

Line:285, valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindOptionsTab.java -> Because this is a Text Box, it will need the 'modifyListener' like the Spinner widgets. Without it modifying the contents of the text box don't register as needing an 'apply' when changed.

-------------------------------------
author: Julian Foster
date: 2015-11-24 23:35:00.000000000

Patch Set 2:

(1 comment)

Line:285, valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindOptionsTab.java -> Good catch!

-------------------------------------
author: Gerrit Code Review
date: 2015-11-25 20:29:55.000000000

Change has been successfully cherry-picked as a59e6e60491e097bc422ca26232c20f5c787cb17 by Nathanael Holden

-------------------------------------
