DESCRIPTION

Bug 471662 - Refactor the run image wizard into a launcher

- fill in the RunDockerImageLaunchConfigurationDelegate
- create main, ports, links, volumes, and environment tabs using
  existing Run Image wizard models and a tab group to group them
- add launch extensions to Docker UI plug-in
- change some existing wizard model classes to add toString() methods
  and create methods that take an output string

Change-Id: I2aefcde43e9b3f239fd89b13db7ec22fd319b9bc


COMMENTS

author: Brenden Conley
date: 2015-11-23 21:55:20.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/10098/

-------------------------------------
author: Brenden Conley
date: 2015-11-23 22:19:03.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/10098/ : SUCCESS

-------------------------------------
author: Zechariah Krause
date: 2015-11-24 13:23:09.000000000

Patch Set 3: Code-Review-1

I get the following error when I run the code and try to create a new launch configuration: 
java.lang.NullPointerException
	at org.eclipse.linuxtools.internal.docker.ui.launch.RunImageResourcesTab.createResourceSettingsContainer(RunImageResourcesTab.java:151)
	at org.eclipse.linuxtools.internal.docker.ui.launch.RunImageResourcesTab.createControl(RunImageResourcesTab.java:68)
	at org.eclipse.debug.internal.ui.launchConfigurations.LaunchConfigurationTabGroupViewer.showInstanceTabsFor(LaunchConfigurationTabGroupViewer.java:819)

-------------------------------------
author: Zechariah Krause
date: 2015-11-24 14:26:48.000000000

Patch Set 3:

(7 comments)

Line:65, containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/launch/RunImageEnvironmentTab.java -> model should be passed in the constructor instead.

Line:25, containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/launch/RunImageLaunchConfigurationTabGroup.java -> What if the model was initialized in the createTabs method and then passed in the constructor of all these tabs ?

Line:84, containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/commands/RunImageCommandHandler.java -> what about moving this method in a utility class ?

Line:91, containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/launch/RunImageVolumesTab.java -> Same problem here: model might be null, leading in NPE in RunImageResourcesTab.createResourceSettingsContainer(RunImageResourcesTab.java:151)

Line:88, containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/launch/RunImageMainTab.java -> With data binding, all those widgets should be declared as local variables, not class fields.

Line:103, containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/launch/RunImageMainTab.java -> model will be null if no connection is available. This might result in NPE later.

Line:261, containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/launch/RunImageMainTab.java -> Why do we need this ? Can't we just rely on the GridDataFactory.grab(boolean, boolean) method to layout the button ?

-------------------------------------
author: Gerrit Code Review
date: 2015-11-27 20:29:09.000000000

Change has been successfully cherry-picked as 973a63e7cf4f298667cb06c5aa76982bf27a71bc by Kaylin Maxwell

-------------------------------------
