DESCRIPTION

tmf: Missing delete action in Filter dialog of ColorsView (bug 458582)

Change-Id: I02d461a8e599b4e51a1f8e6883246bf926d15413
Signed-off-by: Ricky Reeves <Meredith xxx@xxx.xxx


COMMENTS

author: Ricky Reeves
date: 2015-01-27 21:10:02.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2015-01-27 21:46:10.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/9403/

-------------------------------------
author: Brenden Conley
date: 2015-01-27 22:29:05.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/9403/ : SUCCESS

-------------------------------------
author: Luciana Barry
date: 2015-01-28 19:54:31.000000000

Patch Set 2: Code-Review-1

(3 comments)

Line:272, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/Messages.java -> not in alphabetical order

Line:271, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/messages.properties -> not in alphabetical order

Line:211, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/filter/FilterViewer.java -> I think the previous (left) code can be executed in all cases and then only add Delete action for dialogs? The "delete" and "edit" separators can also be common so no need to add new ones.

-------------------------------------
