DESCRIPTION

tmf: fix handler activations in FiltersView (Bug 458579)

Change-Id: I51e616b53dd15c7ebc813c9df299e9b7964e3f1f
Signed-off-by: Ricky Reeves <Meredith xxx@xxx.xxx


COMMENTS

author: Ricky Reeves
date: 2015-01-27 21:10:02.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2015-01-27 21:44:42.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/9401/

-------------------------------------
author: Brenden Conley
date: 2015-01-27 22:13:45.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/9401/ : SUCCESS

-------------------------------------
author: Luciana Barry
date: 2015-01-28 18:57:15.000000000

Patch Set 2: Code-Review-1

(2 comments)

Line:70, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/filter/DeleteHandler.java -> enable

Line:348, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/filter/FilterViewer.java -> This works for our use case, but it is not a correct implementation of the API. The FilterViewer (Composite) is never the focus Control, which should be the actual child control that has keyboard focus (e.g either the Tree or a Text/Combo/Button).

To comply with the API, what you could do is expose the Tree control with a getter and the user can call isFocusControl() on the Tree directly.

Or you can make a new method isTreeInFocus().

-------------------------------------
author: Ricky Reeves
date: 2015-01-28 19:18:31.000000000

Patch Set 2:

(2 comments)

Line:70, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/filter/DeleteHandler.java -> Done

Line:348, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/filter/FilterViewer.java -> Done

-------------------------------------
