DESCRIPTION

Bug 453499: Allow for programmatically adding a connection to the
Control UI

Change-Id: I0b0dab26c455c371d7fab8fb0aaedf2f4401c19d
Signed-off-by: Kaiya Mercado xxx@xxx.xxx

COMMENTS

author: Kaiya Mercado
date: 2014-12-01 07:22:59.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-12-01 07:23:05.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/9306/

-------------------------------------
author: Brenden Conley
date: 2014-12-01 08:04:43.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/9306/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2014-12-01 18:26:28.000000000

Patch Set 2: Code-Review-1

(1 comment)

minor comments

Line:46, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/handlers/NewConnectionHandler.java -> These 2 Strings should be public so that they can be re-used when programmatically execute the command, right?

Also, for the same reason should we define the command ID as public static final String here, too?

-------------------------------------
author: Kaiya Mercado
date: 2014-12-02 06:22:10.000000000

Patch Set 2:

(1 comment)

Line:46, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/handlers/NewConnectionHandler.java -> Done

-------------------------------------
