DESCRIPTION

tmf: Support for state-system based views in live mode

Change-Id: Ida82de56a3bb214e69f68c4c75b5404c925ad76a
Signed-off-by: Alivia Ritter xxx@xxx.xxx


COMMENTS

author: Kaeden Tapia
date: 2014-10-13 16:49:54.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-10-13 16:50:00.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/9200/

-------------------------------------
author: Brenden Conley
date: 2014-10-13 17:41:56.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/9200/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2014-10-15 19:28:14.000000000

Patch Set 1:

(5 comments)

Quick comments from just looking at it. Haven't tested it yet.

Line:686, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/TmfStatisticsViewer.java -> This method could be moved into the scope of the UpdateJob class. Won't change much, but in case we decide one day to be clean(er) and enable the "don't fiddle with internal privates" warning.

Line:117, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/TmfStatisticsViewer.java -> use the high-level interface for declarations (Map), unless there is a specific reason not to (like with TreeMap.floor() etc.)

Line:667, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/TmfStatisticsViewer.java -> these fields could be final

Line:488, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/statesystem/TmfStateSystemAnalysisModule.java -> What is the rationale behind this check? Why not

  if (getRange().getEndTime() > fTimeRange.getEndTime()) {

for instance?

Line:562, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/statesystem/TmfStateSystemAnalysisModule.java -> space after cast!

-------------------------------------
author: Braxton Mccarthy
date: 2014-10-15 20:02:55.000000000

Patch Set 1: Code-Review-1

I deeply apologize, I forgot to put -1 ;)

-------------------------------------
author: Kaeden Tapia
date: 2014-10-15 21:25:14.000000000

Patch Set 1:

(5 comments)

Line:686, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/TmfStatisticsViewer.java -> Done

Line:117, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/TmfStatisticsViewer.java -> just an oversight :p Done.

Line:667, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/TmfStatisticsViewer.java -> Done

Line:488, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/statesystem/TmfStateSystemAnalysisModule.java -> Done

Line:562, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/statesystem/TmfStateSystemAnalysisModule.java -> Done

-------------------------------------
