DESCRIPTION

tmf: add import/export package swtbot tests

Change-Id: Ie4da7c0cd4b9dce58b770f776192d42306f3a291
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2014-09-19 22:28:04.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-09-19 23:30:26.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/9028/

-------------------------------------
author: Brenden Conley
date: 2014-09-20 01:30:43.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/9028/ : ABORTED

-------------------------------------
author: Kaeden Tapia
date: 2014-09-22 14:58:24.000000000

Patch Set 3: Verified-1 Code-Review-1

(5 comments)

Line:32, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestImportExportWizard.java -> This whole javadoc was copy-pasted and needs to be updated.

Line:66, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestImportExportWizard.java -> I think the class name should contain "package" somewhere. TestImportExportPackageWizard

Line:68, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestImportExportWizard.java -> this won't work on Windows and won't be overriddable with the java system property. The java system property should be used instead.

Line:144, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestImportExportWizard.java -> It stops here and fail for me. I think this is expecting that the "overwrite confirmation" message will be shown. This won't be the case if the package has never been written to the temp dir.

Line:146, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestImportExportWizard.java -> This fails for me, it writes 3tmp3test.zip

I use the French (Canada) keyboard layout. It's strange, I though setting SWTBotPreferences.KEYBOARD_LAYOUT would fix this.

-------------------------------------
author: Ivy Mitchell
date: 2014-09-23 12:39:05.000000000

Patch Set 3:

(5 comments)

Line:32, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestImportExportWizard.java -> Done

Line:66, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestImportExportWizard.java -> Done

Line:68, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestImportExportWizard.java -> Done

Line:144, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestImportExportWizard.java -> Done

Line:146, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestImportExportWizard.java -> let's try the other changes and look at this one later. worst case we can change it to setText, but that's less fun.

-------------------------------------
