DESCRIPTION

tmf: Support tool tip for arrows in time graph

The tool tip will show the time link event information of the closest
arrow to the mouse position, provided that it is within 5 pixels.
Holding the Shift key will disable the arrow tool tip so that the tool
tip can show the information of the underlying state.

Change-Id: I5f4daaea130817a16dd5d222b262cb0ec9aee76b
Signed-off-by: Luciana Barry xxx@xxx.xxx


COMMENTS

author: Luciana Barry
date: 2014-09-04 18:31:11.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-09-04 18:31:17.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8716/

-------------------------------------
author: Brenden Conley
date: 2014-09-04 19:14:17.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8716/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2014-09-05 15:19:17.000000000

Patch Set 1: Code-Review-1

(2 comments)

please review the questions and name t more intuitively.

Line:728, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/Utils.java -> dotproduct?

Line:732, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/Utils.java -> t >= 0.0 I think.

-------------------------------------
author: Luciana Barry
date: 2014-09-05 16:07:29.000000000

Patch Set 1:

(2 comments)

Line:728, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/Utils.java -> not really since it is divided by length^2

Line:732, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/Utils.java -> no, that would make the last 3 lines unreachable

-------------------------------------
author: Ivy Mitchell
date: 2014-09-05 17:35:35.000000000

Patch Set 1:

(2 comments)

Line:728, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/Utils.java -> could you name it something other than t? or why t?

Line:732, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/Utils.java -> then please comment this code more... I am lost and I like math. :)

-------------------------------------
author: Gerrit Code Review
date: 2014-09-08 18:52:22.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
