DESCRIPTION

TMF: Fix a bug where the label of an XML XY chart is not considered

Change-Id: I055395e8ab91b0551f54d91fb54ef71d9df4c1a7
Signed-off-by: Aryana Jones xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-09-09 17:57:52.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8856/

-------------------------------------
author: Brenden Conley
date: 2014-09-09 18:39:55.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8856/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2014-09-17 21:18:41.000000000

Patch Set 2: Code-Review-1

(5 comments)

minor things

Line:65, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui/src/org/eclipse/linuxtools/tmf/analysis/xml/ui/module/TmfXmlAnalysisOutputSource.java -> xxx@xxx.xxx String

Line:53, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui/src/org/eclipse/linuxtools/tmf/analysis/xml/ui/module/TmfXmlAnalysisOutputSource.java -> 1.1 here too according to my tool thingy

Line:83, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui/src/org/eclipse/linuxtools/tmf/analysis/xml/ui/module/TmfXmlAnalysisOutputSource.java -> private? (the outer class will still be able to access it)

Line:57, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui/src/org/eclipse/linuxtools/tmf/analysis/xml/ui/module/TmfXmlViewOutput.java -> This will have to be 1.1 now.

Line:83, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui/src/org/eclipse/linuxtools/tmf/analysis/xml/ui/module/TmfXmlViewOutput.java -> does it make sense to save the fViewType in here? Or would just the XmlElem string would be sufficient?

-------------------------------------
author: Annalise Jimenez
date: 2014-09-19 13:47:15.000000000

Patch Set 2:

(1 comment)

Line:83, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui/src/org/eclipse/linuxtools/tmf/analysis/xml/ui/module/TmfXmlViewOutput.java -> fViewType is an enum with a fixed set of values while if we just keep the string, any string could end up here. So I'd rather keep the view type. It will also be easier to add features to it later.

But strictly speaking, yes, in this case and for now, saving just the string would be sufficient...

-------------------------------------
author: Braxton Mccarthy
date: 2014-09-19 18:42:08.000000000

Patch Set 2:

(1 comment)

Line:83, lttng/org.eclipse.linuxtools.tmf.analysis.xml.ui/src/org/eclipse/linuxtools/tmf/analysis/xml/ui/module/TmfXmlViewOutput.java -> Ok, if saving the viewType makes sense semantically, then it's good to do it this way.

-------------------------------------
