DESCRIPTION

ctf: make CtfStreamInput not hold onto any resources

Change-Id: I61cb09c4c325479115084c54bba03d4746cd6610


COMMENTS

author: Kaeden Tapia
date: 2014-09-02 04:47:38.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2014-09-02 05:18:23.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8644/

-------------------------------------
author: Brenden Conley
date: 2014-09-02 05:47:43.000000000

Patch Set 4: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8644/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2014-09-02 13:22:45.000000000

Patch Set 4: -Verified

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8649/

-------------------------------------
author: Brenden Conley
date: 2014-09-02 14:03:03.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8649/ : SUCCESS

-------------------------------------
author: Kaeden Tapia
date: 2014-09-02 15:37:40.000000000

Patch Set 4: Code-Review-1

(4 comments)

Line:376, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFStreamInput.java -> Do we want other classes than CTFStreamInputReader to call this? Should it be package visible? Then we could remove xxx@xxx.xxx and not make this API.

Line:114, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFStreamInputReader.java -> incomplete javadoc?

Line:486, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFStreamInputReader.java -> Incomplete javadoc

Line:491, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFStreamInputReader.java -> How about making this package visible? The way I understand it, CTFStreamInputReader and CTFStreamInputPacketReader are a bit like friend classes and getFc only makes sense when CTFStreamInputPacketReader calls it.

-------------------------------------
