DESCRIPTION

[rfc] statesystem: make state system support longer strings

Make state system support strings over 127 characters long

Change-Id: Iddfe91ce10568310fe33aaf96a231ff7d0bf3828
Signed-off-by: Kason Bridges xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2014-08-28 14:59:40.000000000

Patch Set 2: Commit message was updated

-------------------------------------
author: Dax Sharp
date: 2014-08-28 16:09:03.000000000

Patch Set 2:

What is the maximum number of characters for this new data type? Can it support over 9000 characters? 
I think the maximum size of a string is also limited by the size of the history tree nodes. What is the behaviour if a string is inserted that cannot fit inside a single node?

-------------------------------------
author: Brenden Conley
date: 2014-08-28 16:30:02.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8610/

-------------------------------------
author: Brenden Conley
date: 2014-08-28 16:38:09.000000000

Patch Set 2: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8610/ : FAILURE

-------------------------------------
author: Kason Bridges
date: 2014-08-28 16:52:43.000000000

Patch Set 2:

François: with this new type, 32767 characters. If we do this change, we might as well add another type with 3 or 4 bytes for the size. If you try to add an interval that doesn't fit in a node, I wouldn't be surprised if it went through an infinite loop of "tryInsertAtNode": try to insert node, fail, create new node, repeat.

Here I just did some copy paste, so it's really not maintainable. The proper solution would try to re-use the code as much as possible for all string types.

-------------------------------------
author: Erick Ross
date: 2015-03-06 21:03:36.000000000

Abandoned

Lttng module is separate project now. Consider submitting your patch to
https://projects.eclipse.org/projects/tools.tracecompass .

-------------------------------------
