DESCRIPTION

tmf: lttngControl: mi: save address and offset in hex format

Change-Id: I92be6e050bf407537f06207051077e356e1fe3a0
Signed-off-by: Izaiah Valdez xxx@xxx.xxx


COMMENTS

author: Izaiah Valdez
date: 2014-08-27 17:14:14.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-08-27 17:53:53.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8582/

-------------------------------------
author: Brenden Conley
date: 2014-08-27 18:39:49.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8582/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2014-08-28 12:14:52.000000000

Patch Set 1: Code-Review-1

(2 comments)

Line:872, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> If you store a hex string, you should prepend 0x to make it clear for the user that is is hex.

Line:875, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> same as above

-------------------------------------
author: Izaiah Valdez
date: 2014-08-28 21:13:51.000000000

Patch Set 1:

(1 comment)

Line:872, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> good catch

-------------------------------------
author: Ivy Mitchell
date: 2014-08-29 13:40:22.000000000

Patch Set 1: Code-Review-1

(1 comment)

Line:872, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> don't forget to pad 0s to the desired length. :)

-------------------------------------
author: Izaiah Valdez
date: 2014-08-29 14:43:44.000000000

Abandoned

will be squashed in other commit

-------------------------------------
