DESCRIPTION

tmf: support collapse filter in events table

Change-Id: Iaa87955affa8004764a92e078c51cd854850f44a
Signed-off-by: Ricky Reeves <Meredith xxx@xxx.xxx


COMMENTS

author: Ricky Reeves
date: 2014-09-24 17:33:24.000000000

Uploaded patch set 7.

-------------------------------------
author: Brenden Conley
date: 2014-09-24 17:55:28.000000000

Patch Set 7:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/9061/

-------------------------------------
author: Brenden Conley
date: 2014-09-24 18:51:33.000000000

Patch Set 7: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/9061/ : SUCCESS

-------------------------------------
author: Kaeden Tapia
date: 2014-09-26 04:37:56.000000000

Patch Set 7: Code-Review-1

(4 comments)

Line:1594, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsTable.java -> missing white space

Line:1965, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsTable.java -> shouldn't this always be done even if isCollapseFilter == false because the search icon is always there?

Line:272, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsCache.java -> The index this event *occupies* in the cache

Line:277, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsCache.java -> It looks like you need to do  - 1 here because the count is being passed as the parameter, not the index. I think it would make more sense to do the - 1 where the method is being called instead.

-------------------------------------
author: Ricky Reeves
date: 2014-09-26 11:31:36.000000000

Patch Set 7:

(3 comments)

Line:1965, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsTable.java -> No, otherwise the first column is wider than actually needed for the images (in Linux) and this doesn't look good. Try it and you'll see what I mean.

Line:272, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsCache.java -> Done

Line:277, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsCache.java -> Done

-------------------------------------
