DESCRIPTION

tmf: add filter for collapsing of events in event table

Change-Id: I2641ff7df5039bdd294846f315a6955687aac84c
Signed-off-by: Ricky Reeves <Meredith xxx@xxx.xxx


COMMENTS

author: Ricky Reeves
date: 2014-09-24 17:33:24.000000000

Uploaded patch set 6.

-------------------------------------
author: Brenden Conley
date: 2014-09-24 17:59:21.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/9062/

-------------------------------------
author: Brenden Conley
date: 2014-09-24 18:54:16.000000000

Patch Set 6: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/9062/ : SUCCESS

-------------------------------------
author: Kaeden Tapia
date: 2014-09-25 04:32:17.000000000

Patch Set 6: Code-Review-1

(4 comments)

Minor comments

Line:45, lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/filter/TmfCollapseFilterTest.java -> I think we're using the f prefix in the test classes as well, right? So fCollapsibleEvent1, etc.

Line:40, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/filter/TmfCollapseFilter.java -> maybe this boolean should be called isCollapsible because the part below with if (matches) return false;  looks a bit strange at first glance.

Line:17, lttng/org.eclipse.linuxtools.tmf.core/META-INF/MANIFEST.MF -> the org.eclipse.linuxtools.tmf.ui makes more sense in the next patch, so I think it should be moved if you end up updating this patch.

Line:19, lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/filter/AllTests.java -> Filter. Or just remove the comment?

-------------------------------------
author: Ricky Reeves
date: 2014-09-25 13:38:16.000000000

Patch Set 6:

(4 comments)

I will upload a new version soon

Line:45, lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/filter/TmfCollapseFilterTest.java -> Done

Line:40, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/filter/TmfCollapseFilter.java -> Done

Line:17, lttng/org.eclipse.linuxtools.tmf.core/META-INF/MANIFEST.MF -> Yes, makes sense. It happened after splitting the change into multiple commits.

Line:19, lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/filter/AllTests.java -> Done

-------------------------------------
