DESCRIPTION

tmf: lttngControl: mi: Component and CreateSession tests

Change-Id: I34d0f08bebc08810c99e67a7002a67283bc96c56
Signed-off-by: Izaiah Valdez xxx@xxx.xxx


COMMENTS

author: Izaiah Valdez
date: 2014-08-22 03:59:04.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-08-22 04:47:46.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8493/

-------------------------------------
author: Brenden Conley
date: 2014-08-22 05:24:36.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8493/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2014-08-22 13:35:18.000000000

Patch Set 3: -Verified

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8500/

-------------------------------------
author: Brenden Conley
date: 2014-08-22 14:27:36.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8500/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2014-08-22 15:10:32.000000000

Patch Set 3: -Verified

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8504/

-------------------------------------
author: Brenden Conley
date: 2014-08-22 15:54:31.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8504/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2014-08-22 17:04:35.000000000

Patch Set 3: Code-Review-1

(7 comments)

great start

Line:282, lttng/org.eclipse.linuxtools.lttng2.control.ui.tests/src/org/eclipse/linuxtools/lttng2/control/ui/tests/model/component/TraceControlComponentTest.java -> could you repeat this part above too please?

Line:218, lttng/org.eclipse.linuxtools.lttng2.control.ui.tests/testfiles/CreateSessionTestMi.cfg -> ws

Line:38, lttng/org.eclipse.linuxtools.lttng2.control.ui.tests/src/org/eclipse/linuxtools/lttng2/control/ui/tests/model/component/TraceControlCreateSessionMiTests.java -> 127?

Line:48, lttng/org.eclipse.linuxtools.lttng2.control.ui.tests/src/org/eclipse/linuxtools/lttng2/control/ui/tests/model/component/TraceControlCreateSessionMiTests.java -> 127?

Line:87, lttng/org.eclipse.linuxtools.lttng2.control.ui.tests/src/org/eclipse/linuxtools/lttng2/control/ui/tests/model/component/TraceControlCreateSessionTests.java -> jdoc

Line:246, lttng/org.eclipse.linuxtools.lttng2.control.ui.tests/src/org/eclipse/linuxtools/lttng2/control/ui/tests/model/component/TraceControlCreateSessionTests.java -> getSessionName()?

Line:247, lttng/org.eclipse.linuxtools.lttng2.control.ui.tests/src/org/eclipse/linuxtools/lttng2/control/ui/tests/model/component/TraceControlCreateSessionTests.java -> This strikes me as a bit hard coded...

-------------------------------------
author: Izaiah Valdez
date: 2014-08-22 17:13:52.000000000

Patch Set 3:

(3 comments)

Line:38, lttng/org.eclipse.linuxtools.lttng2.control.ui.tests/src/org/eclipse/linuxtools/lttng2/control/ui/tests/model/component/TraceControlCreateSessionMiTests.java -> this is actually what was there before.. i did not look into it. It does not really matter tbh

Line:246, lttng/org.eclipse.linuxtools.lttng2.control.ui.tests/src/org/eclipse/linuxtools/lttng2/control/ui/tests/model/component/TraceControlCreateSessionTests.java -> nope getName is the correct accessor. it is a traceSessionComponent after all

Line:247, lttng/org.eclipse.linuxtools.lttng2.control.ui.tests/src/org/eclipse/linuxtools/lttng2/control/ui/tests/model/component/TraceControlCreateSessionTests.java -> this is how it was done. I only extracted to method. Other than simply making it into as static string do you have any suggestions?

-------------------------------------
author: Ivy Mitchell
date: 2014-08-22 17:47:30.000000000

Patch Set 3:

(1 comment)

Line:246, lttng/org.eclipse.linuxtools.lttng2.control.ui.tests/src/org/eclipse/linuxtools/lttng2/control/ui/tests/model/component/TraceControlCreateSessionTests.java -> I mean 
private static final String SESSION_NAME = "mysession";
protected String getSessionName(){return SESSION_NAME;}

-------------------------------------
