DESCRIPTION

tmf: lttngControl: mi: support snapshot information

Change-Id: Idac3ad8e3b4166734d6580c7e791e312cd0d6ca0
Signed-off-by: Izaiah Valdez xxx@xxx.xxx


COMMENTS

author: Izaiah Valdez
date: 2014-08-22 03:59:04.000000000

Uploaded patch set 8.

-------------------------------------
author: Brenden Conley
date: 2014-08-22 04:47:45.000000000

Patch Set 8:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8492/

-------------------------------------
author: Brenden Conley
date: 2014-08-22 05:24:36.000000000

Patch Set 8: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8492/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2014-08-22 19:50:32.000000000

Patch Set 8: Code-Review+1 Verified+1

(1 comment)

Line:502, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> This flag is not propagated to the sessionInfo. We agreed to fix it as a separate patch since the same bug exists in the non-MI case.

-------------------------------------
author: Ivy Mitchell
date: 2014-08-25 19:17:22.000000000

Patch Set 8: Code-Review-1

(2 comments)

Line:490, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> we can add this when we have something to populate it with

Line:492, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> useless break

-------------------------------------
author: Izaiah Valdez
date: 2014-08-26 18:12:11.000000000

Patch Set 8:

(3 comments)

Line:490, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> Done moved the todo before the for loop. No warning from eclipse

Line:492, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> Done

Line:502, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> Done

-------------------------------------
