DESCRIPTION

tmf: lttngControl: mi: support snapshot information

Change-Id: Idac3ad8e3b4166734d6580c7e791e312cd0d6ca0
Signed-off-by: Izaiah Valdez xxx@xxx.xxx


COMMENTS

author: Izaiah Valdez
date: 2014-08-16 03:59:03.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-08-16 04:50:31.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8353/

-------------------------------------
author: Brenden Conley
date: 2014-08-16 05:30:25.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8353/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2014-08-19 17:44:12.000000000

Patch Set 3: Code-Review-1

(2 comments)

Line:465, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> SNAPSHOT_DATA_URL  doesn't need to be considered?

What happens if we have a different URL for data and ctrl for snapshots? I'm not familiar with it.

Line:474, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> I think the pattern needs to be updated to support tcp4 in the string

-------------------------------------
author: Izaiah Valdez
date: 2014-08-20 16:45:30.000000000

Patch Set 3:

(2 comments)

Line:465, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> Okai so after talking to Julien Desfossez. We can assume that the host will always be the same. The ctrl and data url correspond to port ... and not host... kind of confusing. Here we should use the data if we want to know the final destination of the snapshot. The use and display of the ctrl url is out of the scope of this patch and should be addressed separately.

Line:474, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> fixed with the use of SNAPSHOT_NETWORK_PATTER from a previous patch.

-------------------------------------
author: Izaiah Valdez
date: 2014-08-21 13:42:14.000000000

Patch Set 3:

(1 comment)

Line:465, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> okai... actually currently lttng store the information into the control url if it is local (file)... i filled a bug on lttng redmine about it.http://bugs.lttng.org/issues/828 for now we will go back to ctrl url

-------------------------------------
