DESCRIPTION

tmf: lttngControl: mi: handle error via errorOutput

Change-Id: Ic54b1dae3013b445ca5f47732a8a22f11f1b0389
Signed-off-by: Izaiah Valdez xxx@xxx.xxx


COMMENTS

author: Izaiah Valdez
date: 2014-08-22 03:59:03.000000000

Uploaded patch set 8.

-------------------------------------
author: Brenden Conley
date: 2014-08-22 03:59:11.000000000

Patch Set 8:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8491/

-------------------------------------
author: Brenden Conley
date: 2014-08-22 04:47:44.000000000

Patch Set 8: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8491/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2014-08-22 13:34:20.000000000

Patch Set 8: -Verified

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8499/

-------------------------------------
author: Brenden Conley
date: 2014-08-22 13:40:05.000000000

Patch Set 8: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8499/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2014-08-22 14:27:36.000000000

Patch Set 8:

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8501/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2014-08-22 14:51:22.000000000

Patch Set 8: -Verified

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8503/

-------------------------------------
author: Brenden Conley
date: 2014-08-22 15:30:02.000000000

Patch Set 8: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8503/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2014-08-25 19:02:24.000000000

Patch Set 8: Code-Review-1

(3 comments)

a little c-p to get rid of

Line:484, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> highlight this and extract maybe into a method that return bool

Line:518, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> copy

Line:681, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> copy?

-------------------------------------
author: Izaiah Valdez
date: 2014-08-25 19:06:11.000000000

Patch Set 8:

(1 comment)

Line:484, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> does this signature suite you? boolean ignoreError(Strinfg [] result.getErrorOuput, String Error_patter) ?

-------------------------------------
author: Ivy Mitchell
date: 2014-08-25 19:15:19.000000000

Patch Set 8:

(1 comment)

Line:484, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> sounds good

-------------------------------------
author: Izaiah Valdez
date: 2014-08-26 18:11:18.000000000

Patch Set 8:

(3 comments)

Line:484, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> Done and ported the change to the regular controlService

Line:518, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> Done

Line:681, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> Done

-------------------------------------
