DESCRIPTION

tmf: lttngControl: TraceLogLvl: add valueOfString utility

Change-Id: Ie0046d483c0bd47115bf0fe05660c13cbcc66ff1
Signed-off-by: Izaiah Valdez xxx@xxx.xxx


COMMENTS

author: Izaiah Valdez
date: 2014-08-22 03:59:04.000000000

Uploaded patch set 8.

-------------------------------------
author: Brenden Conley
date: 2014-08-22 06:37:20.000000000

Patch Set 8:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8498/

-------------------------------------
author: Brenden Conley
date: 2014-08-22 07:10:50.000000000

Patch Set 8: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8498/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2014-08-23 02:55:02.000000000

Patch Set 8: Code-Review-1

(1 comment)

Line:106, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/TraceLogLevel.java -> it is a poor practice to use .values(), could you have a switch case here instead?

-------------------------------------
author: Izaiah Valdez
date: 2014-08-24 18:48:29.000000000

Patch Set 8:

(1 comment)

Line:106, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/TraceLogLevel.java -> In what sense is it a poor practice? The use of a switch case is clunky and hard to maintain. The only reason this could be poor practice is the fact that .values is compiler side functionc. Alternativly i could use  EnumSet.allOf(TraceLogLevel.class)

-------------------------------------
author: Ivy Mitchell
date: 2014-08-25 13:56:30.000000000

Patch Set 8: -Code-Review

(1 comment)

Line:106, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/TraceLogLevel.java -> This actually has a large domain, a switch is less than ideal, -1 revoked.

-------------------------------------
author: Ivy Mitchell
date: 2014-08-25 18:46:38.000000000

Patch Set 8: Verified+1 Code-Review+1

-------------------------------------
