DESCRIPTION

tmf: lttngControl: TraceLogLvl: add valueOfString utility

Change-Id: Ie0046d483c0bd47115bf0fe05660c13cbcc66ff1
Signed-off-by: Izaiah Valdez xxx@xxx.xxx


COMMENTS

author: Izaiah Valdez
date: 2014-08-14 20:42:49.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-08-15 03:35:20.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8304/

-------------------------------------
author: Brenden Conley
date: 2014-08-15 04:00:39.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8304/ : FAILURE

-------------------------------------
author: Ricky Reeves
date: 2014-08-15 11:27:18.000000000

Patch Set 3: Code-Review-1

(2 comments)

JUnit fail (see inline comment)

Line:105, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/TraceLogLevel.java -> Use InvalidArgumentException instead

Line:113, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/TraceLogLevel.java -> You need to update the Junit tests (control.core.tests) for that. We used to return TRACE_DEBUG in that case. However, it should be LEVEL_UNKOWN as you implemented.

-------------------------------------
