DESCRIPTION

tmf: lttngControl: mi: support of domain, channel and event listing

Change-Id: Ia99caf1588c63160e7212d7efb7a61536bec617e
Signed-off-by: Izaiah Valdez xxx@xxx.xxx


COMMENTS

author: Izaiah Valdez
date: 2014-08-16 03:59:04.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2014-08-16 06:44:28.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8359/

-------------------------------------
author: Brenden Conley
date: 2014-08-16 07:21:06.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8359/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2014-08-19 17:22:54.000000000

Patch Set 4: Code-Review-1

(6 comments)

Line:350, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> Add java-doc header

Line:398, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> It is supported  in TMF (option -C). Please add

Line:401, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> It is supported in TMF (option -W). Please add

Line:615, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> private instead of default (package) visibility.

Line:660, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> private?

Line:671, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> For syscalls the name is an empty string. Therefore in the tree there will be an event with no name.

-------------------------------------
author: Izaiah Valdez
date: 2014-08-19 18:05:24.000000000

Patch Set 4:

(6 comments)

Line:350, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> Done

Line:398, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> i missed the attribute.... i start with a Max... anyway fixed

Line:401, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> same. Fixed

Line:615, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> Done

Line:660, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> Done

Line:671, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> fixed. added before adding the event to the list

-------------------------------------
