DESCRIPTION

tmf: implement hashcode and equals on filter classes

Change-Id: Ic72c475995aaf63f3cb2cff83c4a7de395543f30
Signed-off-by: Itzel Singleton xxx@xxx.xxx


COMMENTS

author: Itzel Singleton
date: 2014-08-06 14:47:09.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-08-06 14:47:16.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8113/

-------------------------------------
author: Brenden Conley
date: 2014-08-06 15:30:31.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8113/ : SUCCESS

-------------------------------------
author: Luciana Barry
date: 2014-08-06 18:52:37.000000000

Patch Set 2: Code-Review-1

(5 comments)

Line:164, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/filter/model/TmfFilterMatchesNode.java -> fPattern is derived from fRegex so it does not need to be considered for hashCode() and equals().

Line:233, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/filter/model/TmfFilterCompareNode.java -> fValueNumber and fValueTimestamp are derived from fValue and fType so they do not need to be considered for hashCode() and equals().

Line:151, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/filter/model/TmfFilterContainsNode.java -> fValueUpperCase is derived from fValue so it does not need to be considered for hashCode() and equals().

Line:239, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/filter/model/TmfFilterTreeNode.java -> Need to use Arrays.hashCode()

Line:259, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/filter/model/TmfFilterTreeNode.java -> Need to use Arrays.equals()

-------------------------------------
author: Braxton Mccarthy
date: 2014-08-06 19:15:47.000000000

Patch Set 2:

Just a tip: you can use the "transient" keyword for fields that are not part of the internal state of the object, but are generated from other fields.

Among other things, it won't be enabled by default in the "generate hashCode() and equals()" dialog in Eclipse.

-------------------------------------
author: Luciana Barry
date: 2014-08-06 19:28:26.000000000

Patch Set 2:

(2 comments)

Line:239, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/filter/model/TmfFilterTreeNode.java -> Disregard, ArrayList is not an array

Line:259, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/filter/model/TmfFilterTreeNode.java -> Disregard, ArrayList is not an array

-------------------------------------
