DESCRIPTION

tmf: extract common elements in custom txt/xml trace definitions

Change-Id: Ia381638636ea27f4b295537044f933ce2dcc8068
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-08-06 02:21:51.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8109/

-------------------------------------
author: Brenden Conley
date: 2014-08-06 02:28:27.000000000

Patch Set 2: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8109/ : FAILURE

-------------------------------------
author: Luciana Barry
date: 2014-08-06 18:39:13.000000000

Patch Set 2: Code-Review-1

(3 comments)

Line:397, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/parsers/custom/CustomXmlTraceDefinition.java -> Creates

Line:402, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/parsers/custom/CustomXmlTraceDefinition.java -> As you no doubt have noticed, it's been already added in the dependent patch. But could it be moved to the base class instead?

Line:419, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/parsers/custom/CustomXmlTraceDefinition.java -> idem

-------------------------------------
author: Ivy Mitchell
date: 2014-08-06 20:38:10.000000000

Patch Set 2:

(2 comments)

Line:402, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/parsers/custom/CustomXmlTraceDefinition.java -> static...

Line:419, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/parsers/custom/CustomXmlTraceDefinition.java -> idemer

-------------------------------------
