DESCRIPTION

tmf: lttngControl: BufferType: mi support + utility function

Change-Id: I26f2f965067f9da8aebdca3c4d841956751fc0a8
Signed-off-by: Izaiah Valdez xxx@xxx.xxx


COMMENTS

author: Izaiah Valdez
date: 2014-08-11 18:16:31.000000000

Uploaded patch set 3.

-------------------------------------
author: Ricky Reeves
date: 2014-08-12 18:28:36.000000000

Patch Set 3: Code-Review-1

(2 comments)

Line:102, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/impl/BufferType.java -> Shall we return a default here?

Line:109, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/impl/BufferType.java -> Shall we return a default here?

-------------------------------------
author: Izaiah Valdez
date: 2014-08-14 20:44:55.000000000

Patch Set 3:

(2 comments)

Line:102, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/impl/BufferType.java -> Don't think so because a null miName should not occur

Line:109, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/impl/BufferType.java -> I'm not a fan of garbage in garbage out but at the same time there is an BUFFER_TYPE_UNKNOWN available. It can return the unknown type.

-------------------------------------
