DESCRIPTION

tmf: lttngControl: LogLevelType: mi support + utility function

Change-Id: I6614b61ffa3f21caeaea1a0b03801dda237624a2
Signed-off-by: Izaiah Valdez xxx@xxx.xxx


COMMENTS

author: Izaiah Valdez
date: 2014-08-11 18:16:31.000000000

Uploaded patch set 3.

-------------------------------------
author: Ricky Reeves
date: 2014-08-12 18:28:18.000000000

Patch Set 3: Code-Review-1

(2 comments)

Line:85, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/LogLevelType.java -> This method should be used in EventInfo.setLogLevelType(), too. If so, then EventInfo.setLogLevelType(string) is not needed anymore

Line:87, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/LogLevelType.java -> Shall we return LOGLOVEL_NONE for this case? The same as for the invalid name?

-------------------------------------
author: Izaiah Valdez
date: 2014-08-14 20:44:44.000000000

Patch Set 3:

(2 comments)

Line:85, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/LogLevelType.java -> good point

Line:87, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/LogLevelType.java -> I don't really mind but it make more sense to me to throw an exception in this case because it will mostly be a code error than anything else.

-------------------------------------
