DESCRIPTION

tmf: lttngControl: mi: basic listing support

Change-Id: I8ca572f88d5fff69c27c4f1f345187b3d71b5d0b
Signed-off-by: Izaiah Valdez xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-08-11 21:19:24.000000000

Patch Set 7:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8194/

-------------------------------------
author: Brenden Conley
date: 2014-08-11 21:57:21.000000000

Patch Set 7: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8194/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2014-08-12 01:43:42.000000000

Patch Set 7:

we may or may not need a cq on the xsd... we are allowed to commit it, it's Jonathan's code, but it's under an MIT license and shared with lttng.

-------------------------------------
author: Ricky Reeves
date: 2014-08-12 18:25:58.000000000

Patch Set 7: Code-Review-1

(15 comments)

The code is very clean (well done) and so far I have found only minor comments (this patch and the sub-sequent patches). I haven't reviewed all as well as fully tested. However, I want to sent you my current comments.

Line:160, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/impl/SessionInfo.java -> would it make sense to have a method in TraceSessionState enum class to convert the boolean to the enum vlaue?

Line:54, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> No HTML tags

Line:61, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> Great. By, extending LTTngControlService you only need to update what is needed and can re-use utility methods (e.g. executeCommand())

Line:67, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> do we need to save the docBuilderFactory and schemaFactory? I see it only used in the constructor.

Line:10, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceFactory.java -> It's up to you if want to mention yourself in each file you that changed. Just want to bring it up.

Line:87, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceFactory.java -> The logging is not correct. Here you need to log commandMI then

Line:88, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceFactory.java -> Here you have to log the result of commandMI.

Also, have a try catch block around  execute command and re-throw the exception. This will help to troubleshoot which command failed.

Line:91, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceFactory.java -> here you need to log command.

Line:93, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceFactory.java -> Here you need to log the result.

Line:99, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceFactory.java -> remove the logging here after updating it above

Line:2, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/ISessionInfo.java -> Update year (2014 instead of 2013).
I won't mention it for all files. But please change them all accordingly

Line:23, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/handlers/XmlMiValidationErrorHandler.java -> The HTML tags are not needed. Please remove them. (Sorry, I had them in my original files, but I never got to it to remove them).

Line:2, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/mi_lttng.xsd -> It's MIT license, right?

Line:86, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/mi_lttng.xsd -> Copy paste error? Shoudn't it be something like lttng_context_type?

Line:62, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/messages/Messages.java -> Typo: Required instead of Requiered

-------------------------------------
author: Izaiah Valdez
date: 2014-08-14 20:44:15.000000000

Patch Set 7:

(14 comments)

adjusted to review

Line:160, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/impl/SessionInfo.java -> Sure. but i think i'll simply do the same as with the other enums and add multiple value for the TraceSessionState

Line:67, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java -> Good point. Probably forgot to refactor them after changing the way i did xml parsing.

Line:10, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceFactory.java -> ok

Line:87, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceFactory.java -> Done

Line:88, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceFactory.java -> Done

Line:91, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceFactory.java -> Done

Line:93, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceFactory.java -> Done

Line:99, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/LTTngControlServiceFactory.java -> Done

Line:2, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/ISessionInfo.java -> Done

Line:47, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/ISessionInfo.java -> This has been replaced with the use of valuOfString from TraceSessionState. This change also fit with all the other one made later for mi ussport and thus is more consistent.

Line:23, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/handlers/XmlMiValidationErrorHandler.java -> Done

Line:2, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/mi_lttng.xsd -> Yep do you want me to add a header/comment to it ?

Line:86, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/service/mi_lttng.xsd -> nice catch i'll change it in lttng too.

Line:62, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/messages/Messages.java -> Done

-------------------------------------
