DESCRIPTION

tmf: add constant offset synchronization algorithm and algorithm factory

Change-Id: Ia5b2b49c0e49275b6fa78a16655325a57ab04725
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2014-08-04 16:44:06.000000000

Uploaded patch set 9.

-------------------------------------
author: Brenden Conley
date: 2014-08-04 17:11:43.000000000

Patch Set 9:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8064/

-------------------------------------
author: Annalise Jimenez
date: 2014-08-04 17:25:23.000000000

Patch Set 9: Code-Review+1

looks good

-------------------------------------
author: Brenden Conley
date: 2014-08-04 17:51:35.000000000

Patch Set 9: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8064/ : SUCCESS

-------------------------------------
author: Luciana Barry
date: 2014-08-04 20:50:32.000000000

Patch Set 9: Code-Review-1

(3 comments)

Might not work in theory... but in practice it probably does.

Line:71, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/synchronization/TimestampTransformFactory.java -> If (?!) the offset is larger than Long.MAX_VALUE nanoseconds (using a different scale), this will overflow...

Line:57, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/synchronization/TmfConstantTransform.java -> If (?!) the offset is larger than Long.MAX_VALUE nanoseconds (using a different scale), this will overflow...

Line:63, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/synchronization/TmfConstantTransform.java -> I believe it would better if the offset is normalized to the scale of the provided timestamp and the timestamp returned would be of the same scale as the provided one. Otherwise you could overflow the original timestamp.

-------------------------------------
author: Ivy Mitchell
date: 2014-08-05 04:09:34.000000000

Patch Set 9:

(2 comments)

replies

Line:57, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/synchronization/TmfConstantTransform.java -> that would be 200 years from now though ;)

Line:63, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/synchronization/TmfConstantTransform.java -> Done

-------------------------------------
