DESCRIPTION

pcap: add unit tests to tmf.pcap

Change-Id: I81c12a8d75f99a61931a330e9d80896a77659002
Signed-off-by: Itzel Singleton xxx@xxx.xxx


COMMENTS

author: Itzel Singleton
date: 2014-07-25 18:21:53.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-07-25 18:54:39.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7956/

-------------------------------------
author: Brenden Conley
date: 2014-07-25 19:59:05.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7956/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2014-07-26 04:08:19.000000000

Patch Set 1: Code-Review-1

(2 comments)

overall quite good, the tests are individually smaller than the previous pcap.core test set and that is good.

Line:228, lttng/org.eclipse.linuxtools.tmf.pcap.core.tests/src/org/eclipse/linuxtools/tmf/pcap/core/tests/event/PcapEventFieldTest.java -> odd api here

File Comment: lttng/org.eclipse.linuxtools.tmf.pcap.core.tests/src/org/eclipse/linuxtools/tmf/pcap/core/tests/trace/PcapTraceTest.java -> these are truer unit tests

-------------------------------------
