DESCRIPTION

tmf: add xml wizard ui rudimentary test

Change-Id: I5c51bd14819f3cffd3d8ca7824721da8235fba72
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Kaeden Tapia
date: 2014-09-17 18:47:21.000000000

Uploaded patch set 6.

-------------------------------------
author: Brenden Conley
date: 2014-09-17 18:47:27.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8998/

-------------------------------------
author: Luciana Barry
date: 2014-09-17 19:15:21.000000000

Patch Set 6:

(1 comment)

Line:114, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestCustomTxtWizard.java -> Wouldn't it have been simpler to just make fBot protected?

-------------------------------------
author: Brenden Conley
date: 2014-09-17 19:35:40.000000000

Patch Set 6: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8998/ : SUCCESS

-------------------------------------
author: Kaeden Tapia
date: 2014-09-17 19:41:18.000000000

Patch Set 6:

(1 comment)

Line:103, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestCustomXmlWizard.java -> I think we'll agree that this is really not ideal. I think there should be a comment mentioning which button it's looking for and how it doesn't work with the normal SWTBot means. Like:

// Find "Foo" button. getBot().button("Foo") doesn't work for some reason.

-------------------------------------
author: Kaeden Tapia
date: 2014-09-17 19:41:29.000000000

Patch Set 6: Code-Review-1

-------------------------------------
author: Kaeden Tapia
date: 2014-09-17 22:14:35.000000000

Patch Set 6: -Code-Review

(2 comments)

Line:103, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestCustomXmlWizard.java -> Done. I found a way to find the button with the tooltip.

Line:114, lttng/org.eclipse.linuxtools.tmf.ui.swtbot.tests/src/org/eclipse/linuxtools/tmf/ui/swtbot/tests/TestCustomTxtWizard.java -> Done

-------------------------------------
