DESCRIPTION

tmf: add subfield filtering

Change-Id: I4e7b8ba2ffaf99d95639129ac8b33f673d0673e9
Signed-off-by: Itzel Singleton xxx@xxx.xxx


COMMENTS

author: Itzel Singleton
date: 2014-07-23 13:20:50.000000000

Uploaded patch set 5.

-------------------------------------
author: Brenden Conley
date: 2014-07-23 13:20:56.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7888/

-------------------------------------
author: Itzel Singleton
date: 2014-07-23 13:25:56.000000000

Patch Set 5:

(1 comment)

Line:215, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/filter/model/TmfFilterTreeNode.java -> Finally, we add it even if it is empty, since it is a possible usecase.

If the user has a subfield that has no name, he could still access it this way.

-------------------------------------
author: Brenden Conley
date: 2014-07-23 14:03:12.000000000

Patch Set 5: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7888/ : FAILURE

-------------------------------------
author: Luciana Barry
date: 2014-07-23 15:54:26.000000000

Patch Set 5: Code-Review-1

(3 comments)

Line:158, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/filter/model/TmfFilterTreeNode.java -> .isEmpty()

Line:175, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/filter/model/TmfFilterTreeNode.java -> This will constantly recompute the array with the EQUALS FIELD filter when comparing two subfields. Not sure of the best solution. Should we store up to two conversions per node?

Line:191, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/filter/model/TmfFilterTreeNode.java -> could be simplified:
} else if (charAt == BACKSLASH && i < field.length() - 1 && field.charAt(i + 1) == SLASH) {
  sb.append(SLASH);
  i++;
} else {
  (normal case)

-------------------------------------
author: Itzel Singleton
date: 2014-07-23 17:03:03.000000000

Patch Set 5:

(1 comment)

Line:175, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/filter/model/TmfFilterTreeNode.java -> Yes, but this should be done in the "compare fields" patch.

-------------------------------------
author: Ivy Mitchell
date: 2014-07-23 17:09:29.000000000

Patch Set 5:

I agree with patrick's suggestions

-------------------------------------
author: Gerrit Code Review
date: 2014-07-24 13:55:01.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
