DESCRIPTION

tmf: add subfield filtering

Change-Id: I4e7b8ba2ffaf99d95639129ac8b33f673d0673e9
Signed-off-by: Itzel Singleton xxx@xxx.xxx


COMMENTS

author: Itzel Singleton
date: 2014-07-22 20:26:40.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2014-07-22 21:14:15.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7877/

-------------------------------------
author: Brenden Conley
date: 2014-07-22 21:57:22.000000000

Patch Set 4: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7877/ : FAILURE

-------------------------------------
author: Ivy Mitchell
date: 2014-07-22 22:08:48.000000000

Patch Set 4:

re-triggered, but it failed in event matching, this may actually be a problem

-------------------------------------
author: Ivy Mitchell
date: 2014-07-22 22:12:06.000000000

Patch Set 4:

(2 comments)

Line:213, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/filter/model/TmfFilterTreeNode.java -> sb.toString() should be buffered not created twice. 

sb.toString afaik cannot be null

!sb.toString().isEmpty() please

Line:217, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/filter/model/TmfFilterTreeNode.java -> This is an unnecessary conversion in the fast path... I will discuss this tomorrow w/ patrick

-------------------------------------
author: Brenden Conley
date: 2014-07-22 22:40:28.000000000

Patch Set 4: -Verified

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7881/

-------------------------------------
author: Brenden Conley
date: 2014-07-22 22:42:20.000000000

Patch Set 4: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7881/ : FAILURE

-------------------------------------
author: Itzel Singleton
date: 2014-07-23 03:28:14.000000000

Patch Set 4:

(1 comment)

Line:217, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/filter/model/TmfFilterTreeNode.java -> Actually, this is on the slow path. Patrick found a clever way to generate the array only once, so the performance improved drastically and we don't need to make a new method to get the subfield. Best of both world :)

-------------------------------------
author: Ivy Mitchell
date: 2014-07-23 03:44:53.000000000

Patch Set 4:

(1 comment)

Line:217, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/filter/model/TmfFilterTreeNode.java -> W00t!

-------------------------------------
author: Brenden Conley
date: 2014-07-23 03:45:14.000000000

Patch Set 4: -Verified

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7885/

-------------------------------------
author: Brenden Conley
date: 2014-07-23 04:31:58.000000000

Patch Set 4: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7885/ : FAILURE

-------------------------------------
author: Gerrit Code Review
date: 2014-07-24 13:55:01.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
