DESCRIPTION

tmf: Add thread id to call stack state system

This will optionally be used for sorting threads

Change-Id: Ie38aba65745f123a5195ac1621a749d24fbffa93
Signed-off-by: Luciana Barry xxx@xxx.xxx


COMMENTS

author: Luciana Barry
date: 2014-07-17 14:54:53.000000000

Uploaded patch set 2.

-------------------------------------
author: Ivy Mitchell
date: 2014-07-17 15:45:47.000000000

Patch Set 2: Code-Review-1

(4 comments)

some comments

Line:167, lttng/org.eclipse.linuxtools.lttng2.ust.core/src/org/eclipse/linuxtools/internal/lttng2/ust/core/trace/callstack/LttngUstCallStackProvider.java -> long

Line:102, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/callstack/CallStackStateProvider.java -> long

Line:103, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/callstack/CallStackStateProvider.java -> MinValue.

Line:195, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/callstack/CallStackStateProvider.java -> why not long and return Long.MIN_VALUE if undefined?

-------------------------------------
author: Brenden Conley
date: 2014-07-17 15:48:57.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7775/

-------------------------------------
author: Brenden Conley
date: 2014-07-17 16:15:22.000000000

Patch Set 2: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7775/ : FAILURE

-------------------------------------
author: Luciana Barry
date: 2014-07-17 16:48:19.000000000

Patch Set 2:

(1 comment)

Line:195, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/callstack/CallStackStateProvider.java -> Seems cleaner to me to use null

-------------------------------------
author: Ivy Mitchell
date: 2014-07-17 16:51:25.000000000

Patch Set 2: Code-Review+1

-------------------------------------
author: Brenden Conley
date: 2014-07-17 19:02:44.000000000

Patch Set 2: -Verified

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7782/

-------------------------------------
author: Brenden Conley
date: 2014-07-17 20:00:04.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7782/ : SUCCESS

-------------------------------------
author: Luciana Barry
date: 2014-07-18 14:03:29.000000000

Patch Set 2: Code-Review+2

-------------------------------------
