DESCRIPTION

lttng: Open a live trace and update the events table

With this patch, it becomes possible to import a live
trace session in progress from the Control view. Once it's opened,
the events table updates as more data is available when indicated
by Relayd.

Change-Id: I2470f4c3d4dd2570f4595455d2824806f0dacf09
Signed-off-by: Alivia Ritter xxx@xxx.xxx


COMMENTS

author: Kaeden Tapia
date: 2014-07-09 05:37:20.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-07-09 05:37:26.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7667/

-------------------------------------
author: Brenden Conley
date: 2014-07-09 06:22:39.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7667/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2014-07-14 17:40:26.000000000

Patch Set 2: Code-Review-1

(6 comments)

Looks ok, but there are a few minor nits.

Line:222, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/impl/SessionInfo.java -> I don't think we need finals.

Line:3, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/relayd/messages.properties -> ws

Line:867, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/TmfTrace.java -> should this be set to a field?

Line:874, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/TmfTrace.java -> ditto

Line:78, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/Activator.java -> Do we need to save this? a getInstance like that may need comments if it doesn't have an init after... just a thought.

Line:36, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/relayd/LttngRelaydConnectionInfo.java -> redundant final

-------------------------------------
author: Kaeden Tapia
date: 2014-07-21 17:14:28.000000000

Patch Set 2:

(5 comments)

Line:222, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/model/impl/SessionInfo.java -> eh, Checkstyle is being a bit too aggressive.

Line:3, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/relayd/messages.properties -> Done

Line:874, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/TmfTrace.java -> I added some comments.

Line:78, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/Activator.java -> Done

Line:36, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/relayd/LttngRelaydConnectionInfo.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2014-07-24 15:31:27.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
