DESCRIPTION

tmf: Allow call stack module to override default attribute path

This patch allows a specific implementation of the abstract call stack
analysis module to override the default state system attributes to use.

The call stack state system is also stored in the call stack entry to
avoid computing it repeatedly.

Change-Id: I1541cd639d38944225765e69d7150f1ea8def881
Signed-off-by: Luciana Barry xxx@xxx.xxx


COMMENTS

author: Luciana Barry
date: 2014-07-09 17:44:48.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-07-09 17:44:54.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7673/

-------------------------------------
author: Braxton Mccarthy
date: 2014-07-09 18:15:40.000000000

Patch Set 2: Code-Review-1

(5 comments)

Looks good! Small style comments.

Line:51, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/callstack/CallStackEntry.java -> xxx@xxx.xxx in the Javadoc, explaining what method should be used instead.

Line:204, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/callstack/CallStackEntry.java -> xxx@xxx.xxx ITmfStateSystem

(that's how the new quick-fix in Luna puts it, makes more sense overall)

Line:57, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/callstack/AbstractCallStackAnalysis.java -> These arrays could be defined statically in this class, as to not create a new array every time this method is called.

Line:823, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/callstack/CallStackView.java -> I see what you did there

Line:1190, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/callstack/CallStackView.java -> private xxx@xxx.xxx AbtractCallStackAnalysis...

-------------------------------------
author: Brenden Conley
date: 2014-07-09 18:30:05.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7673/ : SUCCESS

-------------------------------------
