DESCRIPTION

ctf: introducing IDefintion

This is a step in adding a real api to CTF. Now an IDefintion can
be used instead of a definition.

Change-Id: I2f1cea03265afcfd1125ccecff4657324b55ad84
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2014-07-07 21:41:37.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-07-07 21:41:51.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7633/

-------------------------------------
author: Ivy Mitchell
date: 2014-07-07 21:46:28.000000000

Topic set to Ctf cleanup

-------------------------------------
author: Brenden Conley
date: 2014-07-07 22:38:29.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7633/ : SUCCESS

-------------------------------------
author: Luciana Barry
date: 2014-07-08 17:28:03.000000000

Patch Set 1:

(2 comments)

Line:7, /COMMIT_MSG -> IDefinition

Line:9, /COMMIT_MSG -> IDefinition

-------------------------------------
author: Braxton Mccarthy
date: 2014-07-08 18:08:04.000000000

Patch Set 1:

(3 comments)

Line:86, lttng/org.eclipse.linuxtools.tmf.ctf.core/src/org/eclipse/linuxtools/tmf/ctf/core/CtfTmfEventField.java -> You cannot do this. This removes a public method from an API class, which is an API break. Keep it Definition for now.

Line:29, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/types/IDefinition.java -> If this one is "nullable", what does it mean when the returned value is null? The javadoc should specify it.

Line:38, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/types/IDefinition.java -> on the same line

We'll write

  public xxx@xxx.xxx String blahblah()

from now on (that's how the new auto-format makes it)

-------------------------------------
