DESCRIPTION

bug 408543 - Implemented first time auto-enable-checkboxes for gprof.

If the user launches gprof and it is not enabled in the options
then the user will now be prompted if he wants to have the
option enabled for him automatically.
If so, the option is enabled and project is rebuild.

Change-Id: Ib6344a0f8608cc8100142904511d50f0d086fa4f
Signed-off-by: Natalia Golden xxx@xxx.xxx


COMMENTS

author: Natalia Golden
date: 2014-08-25 14:31:09.000000000

Uploaded patch set 12.

-------------------------------------
author: Brenden Conley
date: 2014-08-25 14:44:17.000000000

Patch Set 12:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8527/

-------------------------------------
author: Brenden Conley
date: 2014-08-25 15:20:12.000000000

Patch Set 12: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8527/ : SUCCESS

-------------------------------------
author: Kaylin Maxwell
date: 2014-08-26 21:21:49.000000000

Patch Set 12:

(10 comments)

Line:78, gprof/org.eclipse.linuxtools.gprof.test/src/org/eclipse/linuxtools/internal/gprof/test/GprofLaunchTest.java -> gprof not gcov

Line:88, gprof/org.eclipse.linuxtools.gprof.test/src/org/eclipse/linuxtools/internal/gprof/test/GprofLaunchTest.java -> No Autotools test as well?

Line:5, gprof/org.eclipse.linuxtools.gprof.test/META-INF/MANIFEST.MF -> bump to 4.1.0 and change pom.xml appropriately.

Line:11, gprof/org.eclipse.linuxtools.gprof.launch/src/org/eclipse/linuxtools/internal/gprof/launch/GprofLaunchMessages.properties -> Attribute all code you write to Red Hat Inc...  This goes for other changes in this fix.

Line:48, gprof/org.eclipse.linuxtools.gprof.launch/src/org/eclipse/linuxtools/internal/gprof/launch/GprofLaunchMessages.properties -> There is no gmon profiling.  The output file happens to be called gmon.out.  I would suggest Either Gprof profiling ...  or construct a message similar to the one used for gcov (Gprof profiling support is not enabled....)

Line:52, gprof/org.eclipse.linuxtools.gprof.launch/src/org/eclipse/linuxtools/internal/gprof/launch/GprofLaunchMessages.properties -> Construct messages similar to the ones used for gcov for consistency purposes.

Line:53, gprof/org.eclipse.linuxtools.gprof.launch/src/org/eclipse/linuxtools/internal/gprof/launch/GprofLaunchMessages.properties -> Make these paths look like the one used in gcov for consistency.

Line:59, gprof/org.eclipse.linuxtools.gprof.launch/src/org/eclipse/linuxtools/internal/gprof/launch/GprofLaunchMessages.properties -> Same comment above.  Be consistent with gcov messages.

Line:60, gprof/org.eclipse.linuxtools.gprof.launch/src/org/eclipse/linuxtools/internal/gprof/launch/GprofLaunchMessages.properties -> and here.

Line:65, gprof/org.eclipse.linuxtools.gprof.launch/src/org/eclipse/linuxtools/internal/gprof/launch/GprofLaunchMessages.properties -> Like gcov, mention offering to rebuild as well.

-------------------------------------
