DESCRIPTION

ctf: make BitBuffer's Constructor only take non-null ByteBuffers

Change-Id: I70490af35ea9d1ec559828d81fcb6b65b65d12ca
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2014-06-22 03:38:49.000000000

Uploaded patch set 7.

-------------------------------------
author: Brenden Conley
date: 2014-06-22 03:38:55.000000000

Patch Set 7:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7510/

-------------------------------------
author: Brenden Conley
date: 2014-06-22 04:31:25.000000000

Patch Set 7: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7510/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2014-06-22 04:36:59.000000000

Topic set to CTF performance

-------------------------------------
author: Braxton Mccarthy
date: 2014-06-25 20:41:53.000000000

Patch Set 7: Code-Review-1

(7 comments)

Small style issues.

Also, related to this series, why keep a field fByteOrder? Why not just have the getter and setter pass through to fByteBuffer.order() and fByteBuffer.order(int) ?

Line:45, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/io/BitBufferTest.java -> you import ByteBuffer, no need to use the full package path

Line:90, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/types/ArrayDeclaration2Test.java -> no need for a method if you only use it once, you could keep byb and bb

Line:103, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/types/EnumDeclarationTest.java -> keep it in-line

Line:94, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/types/ArrayDefinition2Test.java xxx@xxx.xxx on its own on line above

Line:104, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/types/ArrayDefinition2Test.java -> same

Line:182, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/types/ArrayDefinition2Test.java -> just like this!

Line:210, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/types/ArrayDefinition2Test.java -> here too, it's used only once, you could put it in-line.

-------------------------------------
author: Ivy Mitchell
date: 2014-06-25 21:33:00.000000000

Patch Set 7:

(7 comments)

Line:45, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/io/BitBufferTest.java -> Done

Line:90, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/types/ArrayDeclaration2Test.java -> Done

Line:103, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/types/EnumDeclarationTest.java -> Done

Line:94, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/types/ArrayDefinition2Test.java -> Done

Line:104, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/types/ArrayDefinition2Test.java -> Done

Line:182, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/types/ArrayDefinition2Test.java -> Done

Line:210, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/types/ArrayDefinition2Test.java -> Done

-------------------------------------
