DESCRIPTION

ctf: make BitBuffer's Constructor only take non-null ByteBuffers

Change-Id: I70490af35ea9d1ec559828d81fcb6b65b65d12ca
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2014-06-18 17:10:13.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-06-18 18:43:08.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7425/

-------------------------------------
author: Brenden Conley
date: 2014-06-18 18:53:46.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7425/ : FAILURE

-------------------------------------
author: Braxton Mccarthy
date: 2014-06-18 20:31:59.000000000

Patch Set 3: Code-Review-1

(10 comments)

Correct spacing for if clauses:

  if<space>(<thing>)<space>{

This seems like a recurring issue...


This change does look a bit painful, but it gives a benefit in some places already. And it forces checking for the off-chance that the allocation fails. I can't really complain about someone xxx@xxx.xxx annotations ;)

For the tests though, you might want to have a static method somewhere that does the null check + throw exception in one place, instead of repeating it almost everywhere.

Line:1, lttng/org.eclipse.linuxtools.ctf.core.tests/results.csv -> o.O

Line:217, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/io/BitBufferTest.java -> Ctrl+Shift+F this file

Line:39, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/types/IntegerEndiannessTest.java -> nooo

put xxx@xxx.xxx after the keywords (after final), that should prevent auto-format from messing with it

Line:338, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFStreamInput.java -> this javadoc is useless just btw

Line:328, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFStreamInput.java -> annotation on a separate line

Line:344, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFStreamInput.java -> For fields, put xxx@xxx.xxx after the modifiers.

For methods, put it on a separate line before xxx@xxx.xxx

Line:56, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/io/BitBuffer.java xxx@xxx.xxx after final (I think this comes from a previous patch anyway)

Line:208, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/types/ArrayDefinitionTest.java -> dude man seriously...

Line:80, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/types/ArrayDeclarationTest.java -> ctrl+shift+f

Line:94, lttng/org.eclipse.linuxtools.ctf.core.tests/src/org/eclipse/linuxtools/ctf/core/tests/types/EnumDeclarationTest.java -> .

-------------------------------------
