DESCRIPTION

tmf: Use a Tree viewer, add sel/desel all in Experiment > Select traces

Change-Id: I9fcc86c5b974a871284d6d25878b0fb528ed5a0c
Signed-off-by: Alivia Ritter xxx@xxx.xxx


COMMENTS

author: Kaeden Tapia
date: 2014-06-16 19:32:30.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-06-16 19:32:36.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7384/

-------------------------------------
author: Brenden Conley
date: 2014-06-16 20:42:40.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7384/ : SUCCESS

-------------------------------------
author: Annalise Jimenez
date: 2014-06-17 15:56:01.000000000

Patch Set 1: Code-Review-1

(3 comments)

Small comment in the setSubtreeChecked method. Looks ok otherwise, but I'll let Patrick or Meredith Scott do a more complete review, as UI stuff is not my specialty.

Line:109, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/SelectTracesWizardPage.java -> You could extract this to a constant and add a little comment.

Line:168, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/SelectTracesWizardPage.java -> Here too that could be extracted to a constant, it is easier if the layout needs to change at some point, but not necessary.

Line:274, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/SelectTracesWizardPage.java -> Redundant with the one below the if?

-------------------------------------
author: Kaeden Tapia
date: 2014-06-18 16:45:26.000000000

Patch Set 1:

(3 comments)

Line:109, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/SelectTracesWizardPage.java -> Done

Line:168, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/SelectTracesWizardPage.java -> Done

Line:274, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/SelectTracesWizardPage.java -> Done

-------------------------------------
