DESCRIPTION

tmf: Integration of the pcap parser within TMF

Change-Id: I1f5cdac29ceaa8e513467965b889bf152d2f4edb
Signed-off-by: Itzel Singleton xxx@xxx.xxx


COMMENTS

author: Itzel Singleton
date: 2014-08-11 13:58:27.000000000

Uploaded patch set 18.

-------------------------------------
author: Brenden Conley
date: 2014-08-11 13:58:33.000000000

Patch Set 18:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8186/

-------------------------------------
author: Brenden Conley
date: 2014-08-11 14:36:31.000000000

Patch Set 18: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8186/ : SUCCESS

-------------------------------------
author: Luciana Barry
date: 2014-08-11 15:24:22.000000000

Patch Set 18: Code-Review+1

-------------------------------------
author: Ricky Reeves
date: 2014-08-11 17:11:16.000000000

Patch Set 18: Code-Review-1

(14 comments)

Matthew asked me to review. I found a few things.

Line:41, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/signal/TmfPacketStreamSelectedSignal.java -> Why would stream be null? The signal shouldn't be sent if the stream is null.

File Comment: lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/internal/tmf/pcap/core/util/messages.properties -> Copyright header is missing

File Comment: lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/event/messages.properties -> Copyright header is missing

Line:3, lttng/org.eclipse.linuxtools.tmf.pcap.core/pom.xml -> 2014, Ericsson

File Comment: lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/internal/tmf/pcap/core/util/Messages.java -> Copyright header is missing

File Comment: lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/event/Messages.java -> Copyright header is missing

Line:3, lttng/org.eclipse.linuxtools.tmf.pcap.ui/pom.xml -> 2014, Ericsson

File Comment: lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/event/PcapEventType.java -> Copyright header is missing

Line:20, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/event/PcapEventType.java -> Oh, boy: SupressWarning xxx@xxx.xxx for something we know it's not null. Side effect of NonNullByDefault :-(

Line:21, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/event/PcapEventType.java -> The context doesn't need to be externalized. It's an internal concept.

Line:27, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/event/PcapEventType.java -> The Default type id doesn't need to be externalized.

Line:61, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/analysis/StreamListAnalysis.java -> I think the request should be created when executing an analysis. The request might be cancelled and a new instance of the request is needed when the analysis is restarted. 

See TmfStateSystemAnalysisModule how you can handle this.

Line:128, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/analysis/StreamListAnalysis.java -> only call cancel if request is not finished (see TmfStateSystemAnalysisModule for an example)

Line:4, lttng/org.eclipse.linuxtools.tmf.pcap.ui/src/org/eclipse/linuxtools/tmf/pcap/ui/stream/messages.properties -> move header to the top

-------------------------------------
author: Ricky Reeves
date: 2014-08-11 17:22:23.000000000

Patch Set 18:

(4 comments)

Question about the icon lisences. (see inline questions)

File Comment: lttng/org.eclipse.linuxtools.tmf.pcap.ui/icons/pcapng.png -> Is this icon under EPL liscence?

File Comment: lttng/org.eclipse.linuxtools.tmf.pcap.ui/icons/stream_list_view.gif -> Is this icon under EPL liscence?

File Comment: lttng/org.eclipse.linuxtools.tmf.pcap.ui/icons/network.png -> Is this icon under EPL lisence?

File Comment: lttng/org.eclipse.linuxtools.tmf.pcap.ui/icons/pcap.png -> Is this icon under EPL liscence?

-------------------------------------
author: Itzel Singleton
date: 2014-08-11 18:51:36.000000000

Patch Set 18:

(15 comments)

Line:41, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/signal/TmfPacketStreamSelectedSignal.java -> This happens when the user clears the selection then the stream sent is null. Thus, the views that use it simply null-check it to know that the selection is cleared and that they should clear themselves.

File Comment: lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/internal/tmf/pcap/core/util/messages.properties -> Done

File Comment: lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/event/messages.properties -> Done

Line:3, lttng/org.eclipse.linuxtools.tmf.pcap.core/pom.xml -> Done

File Comment: lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/internal/tmf/pcap/core/util/Messages.java -> Done

File Comment: lttng/org.eclipse.linuxtools.tmf.pcap.ui/icons/network.png -> All the icons used are in the public domain: http://creativecommons.org/publicdomain/zero/1.0/

File Comment: lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/event/Messages.java -> Done

Line:3, lttng/org.eclipse.linuxtools.tmf.pcap.ui/pom.xml -> Done

File Comment: lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/event/PcapEventType.java -> Done

Line:20, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/event/PcapEventType.java -> This is the only way I found to make it work with both Eclipse and maven :(

Line:21, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/event/PcapEventType.java -> Still externalized after conversation with Meredith Scott.

Line:27, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/event/PcapEventType.java -> Still externalized after conversation with Meredith Scott.

Line:61, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/analysis/StreamListAnalysis.java -> Done

Line:128, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/analysis/StreamListAnalysis.java -> Done

Line:4, lttng/org.eclipse.linuxtools.tmf.pcap.ui/src/org/eclipse/linuxtools/tmf/pcap/ui/stream/messages.properties -> Nice catch!

-------------------------------------
