DESCRIPTION

tmf: Integration of the pcap parser within TMF

Change-Id: I1f5cdac29ceaa8e513467965b889bf152d2f4edb
Signed-off-by: Itzel Singleton xxx@xxx.xxx


COMMENTS

author: Itzel Singleton
date: 2014-08-08 20:51:48.000000000

Uploaded patch set 17.

-------------------------------------
author: Brenden Conley
date: 2014-08-08 20:51:54.000000000

Patch Set 17:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8178/

-------------------------------------
author: Brenden Conley
date: 2014-08-08 21:37:20.000000000

Patch Set 17: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/8178/ : SUCCESS

-------------------------------------
author: Luciana Barry
date: 2014-08-09 04:01:16.000000000

Patch Set 17: Code-Review-1

(6 comments)

Some of the null annotation stuff make my eyes bleed

Line:59, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/trace/PcapTrace.java -> Does PcapFile constructor do any validation on the content of the file? If so, I would be pretty confident to put 100.

Line:81, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/trace/PcapTrace.java -> If you know the number of packets immediately, it's better to use that, as long as seek by ratio uses the same principle. We use number of events when we have nothing else to fall back on. You can remove the comment.

Line:95, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/trace/PcapTrace.java -> synchronized

Line:148, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/trace/PcapTrace.java -> synchronized

Line:205, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/trace/PcapTrace.java -> We probably should set fPcapFile to null here. Then every other method knows when it is too late to use it.

Line:217, lttng/org.eclipse.linuxtools.tmf.pcap.core/src/org/eclipse/linuxtools/tmf/pcap/core/trace/PcapTrace.java -> Maybe synchronize? Does closing the file affect the getters?

-------------------------------------
