DESCRIPTION

tmf: Cleanup Statistics View classes a bit

- Remove useless interfaces
- Change protected fields to private, make some of them static
- Use Immutable List/Set where applicable

Change-Id: Ia351e820ea6d5988074d227d369db9f821374026
Signed-off-by: Braxton Mccarthy xxx@xxx.xxx


COMMENTS

author: Braxton Mccarthy
date: 2014-05-13 18:54:40.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-05-13 19:21:38.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6989/

-------------------------------------
author: Brenden Conley
date: 2014-05-13 19:25:25.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6989/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2014-05-13 23:19:25.000000000

Patch Set 1: -Verified

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7002/

-------------------------------------
author: Brenden Conley
date: 2014-05-14 00:06:22.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7002/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2014-05-14 18:37:57.000000000

Patch Set 1: Code-Review-1

(5 comments)

Line:23, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/model/TmfBaseColumnData.java -> We should remove the version number

Line:125, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/model/TmfBaseColumnData.java -> number spaces! not aligned
Please go over all the java doc in this file since multiple java docs are not correctly aligned

Line:33, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/model/TmfBaseColumnDataProvider.java -> Shall we remove the version?

Line:308, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/TmfStatisticsViewer.java -> comment not correct anymore

Line:312, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/TmfStatisticsViewer.java -> The only advantage I see for using a base implementation instead of an interface is simpler to maintain the API, right? Otherwise there is no need to change it.

-------------------------------------
author: Braxton Mccarthy
date: 2014-05-14 19:59:29.000000000

Patch Set 1:

(4 comments)

Thanks for the comments!

Line:125, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/model/TmfBaseColumnData.java -> oh wow, yes! I copy-pasted the Javadoc from the now-defunct interface, not too sure what happened here...

Line:33, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/model/TmfBaseColumnDataProvider.java -> sure, never really understood what they were for...

Line:308, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/TmfStatisticsViewer.java -> good catch! it was not using xxx@xxx.xxx } so it didn't give any warning :)

Line:312, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/TmfStatisticsViewer.java -> Pretty much. This was an "interface" that was only used in this package, so was not really necessary (and made Vincent's following patches more simple).

-------------------------------------
