DESCRIPTION

tmf: Introduce tmf remote plug-ins and feature

Change-Id: Ibc4e806f35524490ae9c46be356038fd46c3777c
Signed-off-by: Ricky Reeves <Meredith xxx@xxx.xxx


COMMENTS

author: Ricky Reeves
date: 2014-05-12 19:57:41.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-05-12 19:57:46.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6972/

-------------------------------------
author: Brenden Conley
date: 2014-05-12 20:30:55.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6972/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2014-05-13 18:44:33.000000000

Patch Set 3: -Verified

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6987/

-------------------------------------
author: Brenden Conley
date: 2014-05-13 19:21:38.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6987/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2014-05-14 16:05:54.000000000

Patch Set 3: Code-Review-1

(9 comments)

Some comments.

I suggest Marc-André takes a look at it too, he's good to spot small things in those big patches :)

One question, do we want a feature for tmf.remote? Isn't this just a plugin that "real" features, like "lttng remote" will depend on? As in, why would a user install "TMF Remote" by itself?

Line:35, lttng/org.eclipse.linuxtools.tmf.remote.core/pom.xml -> this <resources> block is not needed anymore

Marc-André is right, we should remove it from ALL pom.xml's, or they'll just keep coming back when we copy paste for now features!

Line:35, lttng/org.eclipse.linuxtools.tmf.remote.ui/pom.xml -> this block is not needed anymore

Line:13, lttng/org.eclipse.linuxtools.tmf.remote.core/plugin.properties -> tmf.remote.core

We always forget these little comments... I guess we could just remove them, they're not really useful ;)

Line:5, lttng/org.eclipse.linuxtools.tmf.remote.core/.gitignore -> not needed anymore ;)

Line:27, lttng/org.eclipse.linuxtools.tmf.remote.core/src/org/eclipse/linuxtools/tmf/remote/core/preferences/TmfRemotePreferences.java -> This class should be final

This shows that all methods in here can be static, such that there is no need for a getInstance() at all.

Line:3, lttng/org.eclipse.linuxtools.tmf.remote.ui/src/org/eclipse/linuxtools/internal/tmf/remote/ui/preferences/messages.properties -> whitespace

Line:5, lttng/org.eclipse.linuxtools.tmf.remote.ui/.gitignore -> not needed anymore

Line:37, lttng/org.eclipse.linuxtools.tmf.remote.ui/src/org/eclipse/linuxtools/internal/tmf/remote/ui/Activator.java -> tmf.remote.ui ?

Line:5, lttng/org.eclipse.linuxtools.tmf.remote/.gitignore -> not needed anymore

-------------------------------------
author: Ricky Reeves
date: 2014-05-14 18:01:32.000000000

Patch Set 3:

(9 comments)

Line:35, lttng/org.eclipse.linuxtools.tmf.remote.core/pom.xml -> Done

Line:35, lttng/org.eclipse.linuxtools.tmf.remote.ui/pom.xml -> Done

Line:13, lttng/org.eclipse.linuxtools.tmf.remote.core/plugin.properties -> Done

Line:5, lttng/org.eclipse.linuxtools.tmf.remote.core/.gitignore -> Done

Line:27, lttng/org.eclipse.linuxtools.tmf.remote.core/src/org/eclipse/linuxtools/tmf/remote/core/preferences/TmfRemotePreferences.java -> Done

Line:3, lttng/org.eclipse.linuxtools.tmf.remote.ui/src/org/eclipse/linuxtools/internal/tmf/remote/ui/preferences/messages.properties -> Done

Line:5, lttng/org.eclipse.linuxtools.tmf.remote.ui/.gitignore -> Done

Line:37, lttng/org.eclipse.linuxtools.tmf.remote.ui/src/org/eclipse/linuxtools/internal/tmf/remote/ui/Activator.java -> Done

Line:5, lttng/org.eclipse.linuxtools.tmf.remote/.gitignore -> Done

-------------------------------------
