DESCRIPTION

ctf: add Event header data types

This is a composite datatype described in the examples of the CTF spec,
section 6.1.1 . Right now, chances are that many people will re-use this pattern
so why not enhance its performance.

Change-Id: I2042be35fee38e42680691af879357ebb1aff95b
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2014-07-10 14:37:48.000000000

Uploaded patch set 13.

-------------------------------------
author: Brenden Conley
date: 2014-07-10 14:37:54.000000000

Patch Set 13:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7690/

-------------------------------------
author: Brenden Conley
date: 2014-07-10 15:07:24.000000000

Patch Set 13: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7690/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2014-07-10 15:44:19.000000000

Patch Set 13: -Verified

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7693/

-------------------------------------
author: Brenden Conley
date: 2014-07-10 16:20:17.000000000

Patch Set 13: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7693/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2014-07-10 17:47:57.000000000

Patch Set 13: -Verified

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7694/

-------------------------------------
author: Brenden Conley
date: 2014-07-10 18:31:31.000000000

Patch Set 13: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7694/ : FAILURE

-------------------------------------
author: Braxton Mccarthy
date: 2014-07-10 18:35:45.000000000

Patch Set 13: Code-Review-1

(2 comments)

Looks good, only one small API warning in CTFStream now.

Line:34, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/internal/ctf/core/event/types/composite/EventHeaderDef.java -> oh you're right, it's static final, so ALL_CAPS it is

Line:154, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFStream.java -> Makes sense, however this gives a warning: 

CTFStream.setEventHeader(IEventHeaderDecl) has non-API parameter type IEventHeaderDecl

Perhaps IEventHeaderDecl should be exported?

-------------------------------------
