DESCRIPTION

ctf: add Event header data types

This is a composite datatype described in the examples of the CTF spec,
section 6.1.1 . Right now, chances are that many people will re-use this pattern
so why not enhance its performance.

Change-Id: I2042be35fee38e42680691af879357ebb1aff95b
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2014-07-09 19:36:58.000000000

Uploaded patch set 11.

-------------------------------------
author: Brenden Conley
date: 2014-07-09 19:37:04.000000000

Patch Set 11:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7678/

-------------------------------------
author: Brenden Conley
date: 2014-07-09 20:14:28.000000000

Patch Set 11: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7678/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2014-07-09 22:22:04.000000000

Patch Set 11: Code-Review-1

(5 comments)

Getting there!

Line:37, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/internal/ctf/core/event/types/composite/EventHeaderDef.java -> fFields

In general, put the static fields before the non-static ones.

Line:24, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/internal/ctf/core/event/types/composite/AbstractEventHeaderDecl.java -> This does not define any methods, it could be an interface. Unless you have greater plans for it?

Line:55, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/internal/ctf/core/event/types/composite/EventHeaderCompactDecl.java -> 16 != 5 ??

Line:68, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/internal/ctf/core/event/types/composite/EventHeaderCompactDecl.java -> 32 != 27

Line:155, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFStream.java -> How about having one setter that takes a EventHeaderDeclaration, and another that takes a StructDeclaration? That way you only allow those two types, but without going through a instanceof/throw IllegalThing exception.

-------------------------------------
author: Ivy Mitchell
date: 2014-08-04 14:48:52.000000000

Patch Set 11:

(5 comments)

Line:37, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/internal/ctf/core/event/types/composite/EventHeaderDef.java -> Done

Line:24, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/internal/ctf/core/event/types/composite/AbstractEventHeaderDecl.java -> Done

Line:55, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/internal/ctf/core/event/types/composite/EventHeaderCompactDecl.java -> Done

Line:68, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/internal/ctf/core/event/types/composite/EventHeaderCompactDecl.java -> Done

Line:155, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFStream.java -> Done

-------------------------------------
