DESCRIPTION

ctf: [rfc] Make bitbuffers bytebuffer NonNull and final

This patch tests out if it's worth making bitbuffers buffer non null
(saves on null checks) and final (the vm likes it more?)

To be discussed:
- do we xxx@xxx.xxx (supresswarnings everywhere)
- de we want final BitBuffers, change in way of working.

Change-Id: I7d70da60c99ac624d0a4158c648aefceb34cbc71
Signed-off-by: Ivy Mitchell xxx@xxx.xxx

COMMENTS

author: Ivy Mitchell
date: 2014-05-06 02:08:19.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-05-06 02:15:24.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6863/

-------------------------------------
author: Ivy Mitchell
date: 2014-05-06 03:01:13.000000000

Patch Set 2:

(4 comments)

Line:126, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/StreamInput.java -> this may be useful as a static in BitBuffer xxx@xxx.xxx public final static EMPTY_BIT_BUFFER

Line:128, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/StreamInput.java -> useless?

Line:561, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/io/BitBuffer.java -> The best improvement of the patch

Line:595, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/io/BitBuffer.java -> bitCapacity?

-------------------------------------
author: Brenden Conley
date: 2014-05-06 03:02:27.000000000

Patch Set 2: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6863/ : ABORTED

-------------------------------------
