DESCRIPTION

lttng: Rename lttng2 feature/plugins to lttng2.control

Change-Id: I4e62711ad2a4355758aff4e8dd4dafdd86f91a98
Signed-off-by: Braxton Mccarthy xxx@xxx.xxx


COMMENTS

author: Braxton Mccarthy
date: 2014-04-24 21:43:46.000000000

Uploaded patch set 1.

-------------------------------------
author: Braxton Mccarthy
date: 2014-04-24 23:14:10.000000000

Patch Set 1: Code-Review-1

(2 comments)

Holy schnauzer, this patch is HUGE! Weird that git didn't figure out the renames, and just sees delete + add...

Line:38, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/Activator.java -> gotta update this

Line:34, lttng/org.eclipse.linuxtools.lttng2.control.core/src/org/eclipse/linuxtools/internal/lttng2/control/core/Activator.java -> gotta update this ID

-------------------------------------
author: Brenden Conley
date: 2014-04-25 05:00:18.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6661/

-------------------------------------
author: Brenden Conley
date: 2014-04-25 05:00:55.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6661/ : FAILURE

-------------------------------------
author: Kaeden Tapia
date: 2014-04-25 19:33:40.000000000

Patch Set 1: Verified-1 Code-Review-1

(13 comments)

Comments inline plus:

- The plugins are still referenced in org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki

- lttng/pom.xml needs to be updated

- releng/org.eclipse.linuxtools.releng-site/category.xml needs to be updated

(fails because of NLS missing messages)

Line:24, lttng/org.eclipse.linuxtools.lttng2.control.core.tests/pom.xml -> Should this include "Control" in the name?

Line:38, lttng/org.eclipse.linuxtools.lttng2.control.core.tests/pom.xml -> what's this??

Line:15, lttng/org.eclipse.linuxtools.lttng2.control.ui/plugin.properties -> Control in the name?

Line:24, lttng/org.eclipse.linuxtools.lttng2.control.ui/pom.xml -> Control in the name?

Line:26, lttng/org.eclipse.linuxtools.lttng2.control.ui/src/org/eclipse/linuxtools/internal/lttng2/control/ui/views/messages/Messages.java -> This constant needs to be updated

Line:15, lttng/org.eclipse.linuxtools.lttng2.control.core/plugin.properties -> Should this include "Control" in the name?

Line:20, lttng/org.eclipse.linuxtools.lttng2.control.ui.tests/src/org/eclipse/linuxtools/lttng2/control/ui/tests/AllTests.java -> control

Line:24, lttng/org.eclipse.linuxtools.lttng2.control.ui.tests/pom.xml -> Control in the name?

Line:20, lttng/org.eclipse.linuxtools.lttng2.control.core.tests/src/org/eclipse/linuxtools/lttng2/control/core/tests/model/impl/AllTests.java -> control

Line:15, lttng/org.eclipse.linuxtools.lttng2.control.core.tests/plugin.properties -> Should this include "Control" in the name?

Line:24, lttng/org.eclipse.linuxtools.lttng2.control.core/pom.xml -> Should this include "Control" in the name?

Line:20, lttng/org.eclipse.linuxtools.lttng2.control.core.tests/src/org/eclipse/linuxtools/lttng2/control/core/tests/AllTests.java -> control

Line:15, lttng/org.eclipse.linuxtools.lttng2.control.ui.tests/plugin.properties -> Control in the name?

-------------------------------------
author: Braxton Mccarthy
date: 2014-04-28 17:22:24.000000000

Patch Set 1:

(2 comments)

Line:38, lttng/org.eclipse.linuxtools.lttng2.control.core.tests/pom.xml -> no idea... this was in the original lttng.core.tests/pom.xml. All this just to echo a useless line in the log?? I'll remove it, I guess.

Line:15, lttng/org.eclipse.linuxtools.lttng2.control.core.tests/plugin.properties -> I didn't want to change it at first. But now that we are branding this as "the control plugin", it would make sense to update the name, yes.

-------------------------------------
