DESCRIPTION

LTTng: Remove dependency to LttngKernelTrace in Lttng Kernel analysis module

The helper's appliesToTraceType and the analysis's canExecute methods already
verify if a trace has the necessary requirements to be able to execute the
analysis and it shouldn't matter if it's not the same class.

Also added a unit test that tests the execution of the analysis itself.

Change-Id: Ifeb9ce54165c2ad2d8b8258c3f465a18433c4969
Signed-off-by: Aryana Jones xxx@xxx.xxx


COMMENTS

author: Annalise Jimenez
date: 2014-04-24 01:59:16.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-04-24 09:28:02.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6617/

-------------------------------------
author: Brenden Conley
date: 2014-04-24 10:24:02.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6617/ : SUCCESS

-------------------------------------
author: Kaeden Tapia
date: 2014-04-24 15:04:28.000000000

Patch Set 3: Code-Review-1

(2 comments)

Line:44, lttng/org.eclipse.linuxtools.lttng2.kernel.core.tests/src/org/eclipse/linuxtools/lttng2/kernel/core/tests/analysis/LttngKernelAnalysisTest.java -> assumeTrue(CtfTmfTestTrace.KERNEL.exists());

Line:74, lttng/org.eclipse.linuxtools.lttng2.kernel.core.tests/src/org/eclipse/linuxtools/lttng2/kernel/core/tests/analysis/LttngKernelAnalysisTest.java -> Maybe this should check a bit more stuff after?

        List<Integer> quarks = ss.getQuarks("*");
        assertFalse(quarks.isEmpty());
?

-------------------------------------
author: Braxton Mccarthy
date: 2014-04-24 15:31:58.000000000

Patch Set 3:

(1 comment)

Line:52, lttng/org.eclipse.linuxtools.lttng2.kernel.core.tests/src/org/eclipse/linuxtools/lttng2/kernel/core/tests/analysis/LttngKernelAnalysisTest.java -> for the sake of symmetry, you can do fTrace.dispose() here. (so if you decide to change the test trace, only need to change it in one place).

-------------------------------------
