DESCRIPTION

lttng: Dispose CpuUsageView properly (bug 433212)

Change-Id: Icf14fd5ae9ab9121171216d1b476df209b0a7c9e
Signed-off-by: Ricky Reeves <Meredith xxx@xxx.xxx


COMMENTS

author: Ricky Reeves
date: 2014-04-23 11:49:33.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-04-23 14:40:32.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6584/

-------------------------------------
author: Brenden Conley
date: 2014-04-23 15:07:22.000000000

Patch Set 2: Verified-1

Build Failed 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/6584/ : ABORTED

-------------------------------------
author: Annalise Jimenez
date: 2014-04-23 19:05:28.000000000

Patch Set 2: Code-Review-1

(1 comment)

I can't reproduce the problem, it's probably a Windows thing, but sounds a good practice to dispose of the widgets ;-) One small thing though.

Line:80, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/cpuusage/CpuUsageView.java -> You should probably call super.dispose() here too

-------------------------------------
author: Kaeden Tapia
date: 2014-04-24 04:39:03.000000000

Patch Set 2:

(1 comment)

Fixed the comment and rebased.

Line:80, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/cpuusage/CpuUsageView.java -> Done

-------------------------------------
